fix: hook GetRawInputData to block mouse clicks from reaching game through menu#959
Open
Abdelakil wants to merge 5 commits into
Open
fix: hook GetRawInputData to block mouse clicks from reaching game through menu#959Abdelakil wants to merge 5 commits into
Abdelakil wants to merge 5 commits into
Conversation
tuyilmaz
reviewed
Jul 9, 2026
| { | ||
| auto result = BaseHook::Get<RawInput::GetRawInputData, DetourHook<decltype(&RawInput::GetRawInputData)>>()->Original()(hRawInput, uiCommand, pData, pcbSize, cbSizeHeader); | ||
|
|
||
| if (result > 0 && pData && uiCommand == RID_INPUT && GUI::IsOpen()) |
Contributor
There was a problem hiding this comment.
I think it'd be better if this only blocks the clicks that are on the menu.
Blocks clicks using ImGui::GetIO().WantCaptureMouse instead of blanket-blocking all clicks when menu is open. Lets clicks pass through to the game for areas outside the menu.
Contributor
Author
|
Addressed review feedback: now only blocks raw mouse clicks when the click lands on the ImGui menu (via ImGui::GetIO().WantCaptureMouse), instead of blocking all clicks while the menu is open. Clicks outside the menu pass through to the game. |
Contributor
Author
|
@tuyilmaz @ShinyWasabi updated per feedback — now only blocks raw mouse clicks when cursor is over the menu (WantCaptureMouse). Ready for re-review. |
tuyilmaz
reviewed
Jul 21, 2026
| auto result = BaseHook::Get<RawInput::GetRawInputData, DetourHook<decltype(&RawInput::GetRawInputData)>>()->Original()(hRawInput, uiCommand, pData, pcbSize, cbSizeHeader); | ||
|
|
||
| if (result > 0 && pData && uiCommand == RID_INPUT && GUI::IsOpen()) | ||
| if (result > 0 && pData && uiCommand == RID_INPUT && GUI::IsOpen() && ImGui::GetIO().WantCaptureMouse) |
Contributor
There was a problem hiding this comment.
io.WantCaptureMouse already checks if the UI is visible. We don't need GUI::IsOpen()
WantCaptureMouse already implies menu is visible.
Contributor
Author
|
Addressed — removed GUI::IsOpen(). WantCaptureMouse alone covers it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When YimMenuV2 is open and the user clicks on a menu option, the click also passes through to the game window because GTA V Enhanced reads mouse input via Raw Input (GetRawInputData), not WM_LBUTTONDOWN/WM_RBUTTONDOWN.
This hooks GetRawInputData and zeroes out mouse button flags when the menu is open, preventing the game from seeing clicks that ImGui has already consumed.
No behavioral changes when the menu is closed.