Skip to content

Adding link of action to timeline #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YanivZalach wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding link of action to timeline #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions frontend/src/pages/DocsPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,13 @@ const SECTIONS = [
expanded or collapsed with <strong className="text-white">▼</strong>{" "}
/ <strong className="text-white">▲</strong>.
</p>
<p>
When the event's snapshot points at the job that wrote it, an{" "}
<strong className="text-white">
<code>action_link</code>
</strong>{" "}
row links out to it, opening in a new tab.
</p>
</div>
</div>
),
Expand Down
44 changes: 44 additions & 0 deletions frontend/src/pages/TimelinePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,35 @@ function DiffRow({ label, before, after }) {
);
}

function SnapOperationDescription({ operation, operationDescription }) {
if (!operationDescription || operationDescription === operation) return null;
return (
<PanelDetailRow
label="Operation Description"
value={operationDescription}
/>
);
}

function SnapActionLink({ actionLink }) {
if (!actionLink) return null;
return (
<div>
<span className={`block ${PANEL_FIELD_LABEL_CLASS} mb-1`}>
action_link
</span>
<a
href={actionLink}
target="_blank"
rel="noopener noreferrer"
className="block font-mono text-xs text-accent hover:text-accent-dark break-all"
>
{actionLink}
</a>
</div>
);
}

function SnapSummary({ summary }) {
const entries = summary ? Object.entries(summary) : [];
if (entries.length === 0) return null;
Expand Down Expand Up @@ -996,6 +1025,11 @@ export default function TimelinePage() {
label="Operation"
value={selectedSnap.operation}
/>
<SnapOperationDescription
operation={selectedSnap.operation}
operationDescription={selectedSnap.operation_description}
/>
<SnapActionLink actionLink={selectedSnap.action_link} />
<SnapSummary summary={selectedSnap.summary} />
</>
)}
Expand All @@ -1018,6 +1052,11 @@ export default function TimelinePage() {
label="Operation"
value={selectedSnap.operation}
/>
<SnapOperationDescription
operation={selectedSnap.operation}
operationDescription={selectedSnap.operation_description}
/>
<SnapActionLink actionLink={selectedSnap.action_link} />
<SnapSummary summary={selectedSnap.summary} />
</>
)}
Expand Down Expand Up @@ -1056,6 +1095,11 @@ export default function TimelinePage() {
label="Operation"
value={selectedSnap.operation}
/>
<SnapOperationDescription
operation={selectedSnap.operation}
operationDescription={selectedSnap.operation_description}
/>
<SnapActionLink actionLink={selectedSnap.action_link} />
<SnapSummary summary={selectedSnap.summary} />
</>
)}
Expand Down
Loading