Feat/tanstack router swap - #139
Open
Razberrry wants to merge 7 commits into
Open
Conversation
Behavior-identical router swap per the approved plan: - File routes under src/routes/ (pathless _shell layout keeps 404s blank; /table parent preserves the no-remount tab-switch guarantee) - Custom string-only parseSearch/stringifySearch: snapshot IDs exceed Number.MAX_SAFE_INTEGER and must never be JSON-parsed; URLSearchParams serialization keeps dup/cache_id URLs byte-identical - z.looseObject search schemas so unknown params survive carry-forward - Outlet context replaced by features/table/tableGraphData.ts - Mock-mode redirects moved to beforeLoad; QueryClientProvider added (unused until page migrations) - main.jsx/App.jsx replaced by main.tsx + routes; react-router-dom still installed until final removal commit Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The five raw history.pushState/replaceState sites replaced the whole history.state object, clobbering the index TanStack Router stores there. Spread the existing state so back/forward tracking survives graph-selection navigation. graphSelection behavior unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SKILL.md URL contract re-verified — no change needed (all params, routes, and semantics identical). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A first-visit tab chunk suspending reached the root Suspense boundary, whose fallback unmounted TableLayout — re-running its mount effect and wiping the graph selection (sessionStorage cleared). Caught by the browser smoke suite; boundary below TableLayout restores the pre-swap no-remount behavior (plan risk R5's designated mitigation). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Remove @tanstack/react-query + QueryClientProvider; nothing consumed them, they were staged for a later page migration - Flatten routes/_shell/** to routes/**; NavBar moves into __root.tsx. The pathless layout existed only so unknown URLs rendered without a NavBar; that parity isn't worth a whole nesting level, so a 404 now shows the NavBar with no page content Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…om import The master merge kept both sides' import blocks in FileTreePage, declaring FileType twice (ESLint parse error, failing CI) and reintroducing useOutletContext from react-router-dom, which this branch removed as a dependency and no longer calls.
Owner
|
Spreading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced with tanstack router for better type support, and the echo system