Final QA fixes by Akhill2020 · Pull Request #692 · Xtendify/Simple-Calendar

Akhill2020 · 2026-05-26T10:11:03Z

Description: Fix below points.
*in case of core update we can show misc settings
*on welcome page remove extra text as per suggetions

if already have setup then welcome page should not show also remove top padding from welcom and make singe color
existing user should show there their connection type
rate us one link add filter=5 to show rating
api key field belwo helper text should be in one line
on activating appointment it should show notice for core update and in the name add "add-on"
After: https://drive.google.com/file/d/1tC7I0gym5FjJzQXkWA_LeSNc7iRclSLx/view?usp=drivesdk

Summary by CodeRabbit

Bug Fixes
- Removed settings access restriction related to add-on version compatibility checks.
Style
- Updated Connect page layout and styling for improved visual presentation.
- Refreshed welcome page messaging and interface elements.
Chores
- Updated external resource links for WordPress.org ratings.

coderabbitai · 2026-05-26T10:11:18Z

📝 Walkthrough

Walkthrough

The PR establishes a unified Connect onboarding initialization system that detects existing credentials, auto-dismisses welcome steps, manages Pro connection type selection, refines the Connect UI, and removes Pro compatibility restrictions from settings access.

Changes

Connect Onboarding Initialization and UI Refinement

Layer / File(s)	Summary
Overlay styling migration and Connect welcome updates `assets/css/admin-add-calendar.css`, `assets/scss/admin-global.scss`, `assets/scss/connect.scss`, `includes/admin/pages/connect/steps/welcome.php`, `includes/admin/pages/connect/partials/google-calendar-api-key-connect.php`, `includes/admin/pages/connect/sidebar.php`	Migrates settings mask overlay from CSS to global SCSS, updates Connect page layout with flex-based helper text, refines welcome step copy for Pro and default contexts, restructures helper text markup nesting, and updates WordPress.org link parameters.
Connect configuration detection and state initialization `includes/functions/admin.php`	Introduces detection functions for core and Pro Connect credentials, auto-dismisses welcome steps when existing configuration is found, determines Pro connection type based on token availability and OAuth health, and provides a coordinator function to apply all defaults.
Plugin activation, upgrade, and redirect handling `includes/installation.php`, `includes/main.php`, `includes/update.php`	Hooks Connect defaults into plugin activation and upgrade events, validates upgrade context and detects updated plugins, applies defaults on activation/upgrade, determines which Connect welcome to show post-activation based on Pro status and existing config, and consolidates Update logic to delegate to the coordinator.
Settings page access cleanup `includes/admin/pages.php`	Removes Pro add-on version compatibility guard that previously blocked Settings page access, allowing the settings page to load unconditionally.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Xtendify/Simple-Calendar#680: Both PRs modify the same Connect onboarding UI in google-calendar-api-key-connect.php and adjust Pro-version helper markup.
Xtendify/Simple-Calendar#688: Both PRs touch the shared .simcal-settings-mask overlay styling in CSS and SCSS assets.
Xtendify/Simple-Calendar#639: Both PRs modify includes/installation.php activation-time behavior, with the main PR injecting Connect defaults before clearing transients.

Suggested reviewers

rosinghal
enginnk

Poem

🐰 Hop along the onboarding way,
Where credentials skip their intro play—
Defaults set when gates swing wide,
Pro or core, side by side!
Welcome screens know where you've been,
Let the calendar dance begin!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title "Final QA fixes" is vague and generic, using non-descriptive language that fails to convey meaningful information about the specific changes in the changeset.	Use a more specific and descriptive title that highlights the main change, such as "Refactor Connect onboarding flow and update welcome page messaging" or similar.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch issue/revamp-QA-fixes

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.1.55)

PHP Warning: require(/vendor/composer/../guzzlehttp/promises/src/functions_include.php): Failed to open stream: No such file or directory in /vendor/composer/autoload_real.php on line 39
Warning: require(/vendor/composer/../guzzlehttp/promises/src/functions_include.php): Failed to open stream: No such file or directory in /vendor/composer/autoload_real.php on line 39
PHP Fatal error: Uncaught Error: Failed opening required '/vendor/composer/../guzzlehttp/promises/src/functions_include.php' (include_path='.:/usr/share/php') in /vendor/composer/autoload_real.php:39
Stack trace:
#0 /vendor/composer/autoload_real.php(43): {closure}()
#1 /vendor/autoload.php(25): ComposerAutoloaderInit9c9628efc5a6c4ce96ee37a7bd6bdf64::getLoader()
#2 phar:///usr/bin/phpstan/bin/phpstan(46): require_once('...')
#3 phar:///usr/bin/phpstan/bin/phpstan(107): _PHPStan_33c983f26{closure}()
#4 /usr/bin/phpstan(7): require('...')
#5 {main}
thrown in /vendor/composer/autoload_real.php on line 39
Fatal error: Uncaught Error: Failed opening required '/vendor/composer/../guzzlehttp/promises/src/functions_include.php' (include_path='.:/usr/share/php') in /vendor/composer/autoload_real.php:39
Stack trace:
#0 /vendor/composer/autoload_real.php(43): {closure}()
#1 /vendor/autoload.php(25): ComposerAutoloaderInit9c9628efc5a6c4ce96ee37a7bd6bdf64::getLoader()
#2 phar:///usr/bin/phpstan/bin/phpstan(46): require_once('...')
#3 phar:///usr/bin/phpstan/bin/phpstan(107): _PHPStan_33c983f26{closure}()
#4 /usr/bin/phpstan(7): require('...')
#5 {main}
thrown in /vendor/composer/autoload_real.php on line 39

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@includes/admin/pages/connect/steps/welcome.php`:
- Line 72: Replace the generic alt text "Welcome" used in the img tag that calls
esc_attr_e(...) with either a meaningful description (for example "Simple
Calendar setup video placeholder") or an empty alt (alt="") if the image is
purely decorative; update the string passed to esc_attr_e in the img element in
includes/admin/pages/connect/steps/welcome.php accordingly so screen readers
receive an appropriate alt value.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a3749064-3632-44b1-a79a-01b286a1b3f4

📥 Commits

Reviewing files that changed from the base of the PR and between 2438487 and 1d29d3f.

📒 Files selected for processing (11)

assets/css/admin-add-calendar.css
assets/scss/admin-global.scss
assets/scss/connect.scss
includes/admin/pages.php
includes/admin/pages/connect/partials/google-calendar-api-key-connect.php
includes/admin/pages/connect/sidebar.php
includes/admin/pages/connect/steps/welcome.php
includes/functions/admin.php
includes/installation.php
includes/main.php
includes/update.php

💤 Files with no reviewable changes (2)

includes/admin/pages.php
assets/css/admin-add-calendar.css

rosinghal · 2026-05-26T10:58:54Z

+	{
+		unset($upgrader);
+
+		if (


Move below logic to simcal_apply_connect_defaults_on_plugin_update. This can be called from pro as well as appointment addons.

Final QA fixes

1d29d3f

Akhill2020 requested a review from rosinghal May 26, 2026 10:11

coderabbitai Bot reviewed May 26, 2026

View reviewed changes

Comment thread includes/admin/pages/connect/steps/welcome.php

rosinghal reviewed May 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final QA fixes#692

Final QA fixes#692
Akhill2020 wants to merge 1 commit into
mainfrom
issue/revamp-QA-fixes

Akhill2020 commented May 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 26, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

rosinghal May 26, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Akhill2020 commented May 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rosinghal May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Akhill2020 commented May 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 26, 2026 •

edited

Loading