fix: build macOS per-arch so the claude sidecar notarizes#388
Merged
Conversation
The bundled claude runtime embeds a per-slice Info.plist; codesign corrupts the non-native slice's seal when re-signing a universal binary, so notarization rejected the x86_64 claude (and cascaded to the app binary). Build macOS per-arch like Windows/Linux instead, each bundling its single-arch claude, which re-signs cleanly. Updater bundles are renamed per-arch and published to their own darwin slots.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates a comment in download-sidecars.mjs to clarify that universal macOS builds (via lipo) are intended only for local development. It explains that the release pipeline builds macOS per-architecture because codesigning a merged FAT binary corrupts the per-slice Info.plist seal, which fails Apple notarization. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled claude runtime embeds a per-slice Info.plist; codesign
corrupts the non-native slice's seal when re-signing a universal
binary, so notarization rejected the x86_64 claude (and cascaded to
the app binary). Build macOS per-arch like Windows/Linux instead, each
bundling its single-arch claude, which re-signs cleanly. Updater
bundles are renamed per-arch and published to their own darwin slots.