feat(say): facelift — send-then-confirm ordering, cleaner copy#59
Merged
Conversation
Behavior change: channel.send fires BEFORE the ephemeral confirmation. If the bot lacks Send permission in the channel and channel.send throws, the catch fires and errorHandler can still reply because the interaction hasn't been replied to yet. The original ordering replied first, so a failed send left the user with 'Listo.' but no actual message in the channel. Cosmetic: - description: 'Xiza Bot repite lo que dices' → 'Repite un mensaje en el canal' - option message: 'Texto a repetir' → 'Texto a publicar' - option as_embed: 'Mandarlo como embed' → 'Publicar como embed (default: false)' - confirmation: 'Listo.' → '✅ Mensaje enviado.' - examples added Branded as_embed embed intentionally keeps the white color and NO footer — this command is a moderator amplifying a message, not a bot-branded announcement. The brand convention applies to bot-voice embeds, not to content the bot is repeating on someone's behalf. Tests: send-before-reply ordering, embed-shape (no footer/author), existing perm-rejection + ManageMessages check kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Primer comando del facelift de mod (1/6).
/sayya andaba bien funcionalmente; este PR aplica un fix de ordering relevante y limpia los strings.Cambios
Behavior fix
channel.sendahora se ejecuta antes delinteraction.replyde confirmación. Si el bot no tiene permisoSend Messagesen el canal ychannel.sendfalla, el catch dispara yerrorHandlerpuede responder porque la interaction aún no fue replied. La versión anterior respondía 'Listo.' primero y dejaba al usuario sin saber que el mensaje nunca se publicó.Cosmético
Branding decision (no aplico el footer)
El embed cuando `as_embed:true` mantiene white color y sin footer Xiza Bot. La convención de branding aplica a embeds de voz-del-bot; `/say` está amplificando un mensaje del moderador y debe leerse como tal, no como anuncio del bot.
Test plan