Avoid always regenerating aie spec files#304
Draft
jorickert wants to merge 1 commit into
Draft
Conversation
Replace custom targets that directly ran the spec generators with custom commands that declare their outputs and inputs. This lets CMake skip regeneration when the inputs are unchanged. Signed-off-by: Jonas Rickert <jonas.rickert@amd.com>
jorickert
force-pushed
the
jrickert.aiebu_no_rebuild
branch
from
11f85e6 to
0658ebd
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Replace custom targets that directly ran the spec generators with custom commands that declare their outputs and inputs. This lets CMake skip regeneration when the inputs are unchanged.
This prevents unneeded rebuilds by targets that depend on isa.h