Skip to content

Make board-validation PR comment posting non-blocking on restricted token permissions#795

Merged
ADubeyAMD merged 2 commits into
2024.2from
copilot/fix-validate-board-files-job
Jun 4, 2026
Merged

Make board-validation PR comment posting non-blocking on restricted token permissions#795
ADubeyAMD merged 2 commits into
2024.2from
copilot/fix-validate-board-files-job

Conversation

Copilot AI commented Jun 4, 2026

Copy link
Copy Markdown

Validate Board Files was failing for reasons unrelated to board content validation: the PR comment step errored with Resource not accessible by integration when token permissions were limited (e.g., fork PR context). This change ensures enforcement is driven by validation results, not comment-posting permissions.

  • Workflow reliability

    • Updated .github/workflows/board_pr_validation.yml so Post validation report as PR comment does not fail the job when GitHub API write access is unavailable.
    • Keeps report-commenting best-effort while preserving validation execution and failure gating behavior.
  • Behavioral impact

    • Validation logic and fail criteria remain unchanged.
    • Only the comment publication path is made non-blocking.
- name: Post validation report as PR comment
  if: always()
  continue-on-error: true
  uses: actions/github-script@v7

@xilinxgitops

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'Validate Board Files' Make board-validation PR comment posting non-blocking on restricted token permissions Jun 4, 2026
Copilot AI requested a review from ADubeyAMD June 4, 2026 07:48
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

🔍 Board Pre-Validation Report

No board files (under boards/) were changed in this pull request.

@ADubeyAMD ADubeyAMD marked this pull request as ready for review June 4, 2026 08:14
@ADubeyAMD ADubeyAMD merged commit 575d230 into 2024.2 Jun 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants