Skip to content

Add comprehensive CLI reference and skill documentation - #4

Open
XiaotingChen wants to merge 2 commits into
mainfrom
skill
Open

Add comprehensive CLI reference and skill documentation#4
XiaotingChen wants to merge 2 commits into
mainfrom
skill

Conversation

@XiaotingChen

Copy link
Copy Markdown
Owner

Summary

This PR adds two new documentation files to provide comprehensive guidance on using the maxATAC CLI toolkit: a detailed command reference and a skill definition for AI assistants.

Changes Made

  • REFERENCE.md: Complete CLI reference documentation covering all 11 maxatac subcommands (data, prepare, average, normalize, predict, train, threshold, peaks, benchmark, variants). For each subcommand, includes:

    • Purpose and usage examples
    • Required and optional flags with defaults
    • Output file descriptions
    • Implementation notes where relevant
  • SKILL.md: AI assistant skill definition providing:

    • Overview of maxATAC's purpose and capabilities
    • Installation instructions with dependency requirements
    • Quick-start workflow for typical use cases (prepare → predict → benchmark)
    • Subcommand quick-reference table
    • Common pitfalls and troubleshooting guidance
    • Pointer to REFERENCE.md for detailed flag documentation

Notable Details

  • REFERENCE.md documents all flag aliases and variations (e.g., -n/--name/--prefix) to help users discover correct syntax
  • Both files emphasize key constraints: TensorFlow 2.14.0 pinning, hg38-specific model training, and the -slop 20 default that must match for pretrained model compatibility
  • SKILL.md is structured as a Claude skill definition (YAML frontmatter + markdown) for integration with AI assistant systems
  • Documentation includes concrete examples for most subcommands to illustrate typical workflows

https://claude.ai/code/session_015q4D4NyYsATVTN3V3kiMrt

Adds root-level SKILL.md and REFERENCE.md so Claude can use maxATAC
as a Skill: constructing correct maxatac CLI commands, understanding
required inputs/outputs for each subcommand, and chaining prepare ->
predict/train/benchmark workflows, without duplicating the existing
docs/readme/*.md content.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4da73ccac6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +136 to +138
maxatac predict -tf CTCF --signal GM12878_IS_slop20_RP20M_minmax01.bw -o outputdir/
maxatac predict -tf CTCF --signal GM12878_IS_slop20_RP20M_minmax01.bw --roi ROI.bed
maxatac predict -tf CTCF --signal GM12878_IS_slop20_RP20M_minmax01.bw --chromosomes chr3 chr5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add required names to predict examples

When users copy these predict examples, they will fail before running because maxatac/utilities/parser.py registers -n/--name/--prefix for predict with required=True. The reference then lists the prefix as required below, so the examples should include something like -n GM12878_CTCF; otherwise the new reference's primary predict workflow is not runnable.

Useful? React with 👍 / 👎.

ChIP-seq-derived gold-standard bigwig (1 = TFBS, 0 = no TFBS).

```bash
maxatac benchmark --prediction GM12878_CTCF_chr1.bw --gold_standard GM12878_CTCF_ENCODE_IDR.bw --chromosomes chr1 --bin_size 200

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use supported benchmark input flags

In the benchmark parser the prediction input is only accepted via the mutually exclusive -bed/--bed or --bw/--bigwig/-bw options, and a prefix is required via -n/--name/--prefix; there is no --prediction flag. Copying this example will therefore hit argparse's required input/prefix errors instead of benchmarking, so update it to use --bw ... -n ... (or the BED equivalent).

Useful? React with 👍 / 👎.

|---|---|
| `--genome` | Genome build. |
| `-m`, `--model` | Trained `.h5` model. |
| `-i`, `-s`, `--signal` | ATAC-seq signal bigwig. |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reserve -s for variants sequence

For maxatac variants, -s is already the sequence option, while the signal bigwig is defined as -i, -bw, -signal, or --signal in the parser. Documenting -s as the signal flag will make commands generated from this table either fail the required input_bigwig check or pass the bigwig path as a sequence file, so remove -s from this row and keep it only under sequence.

Useful? React with 👍 / 👎.

Restructure into the skills/<name>/SKILL.md convention instead of a
root-level SKILL.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants