Skip to content

refactor: Retire Clawback amendment#7353

Open
TimothyBanks wants to merge 3 commits into
XRPLF:developfrom
TimothyBanks:retire_clawback_amendment
Open

refactor: Retire Clawback amendment#7353
TimothyBanks wants to merge 3 commits into
XRPLF:developfrom
TimothyBanks:retire_clawback_amendment

Conversation

@TimothyBanks
Copy link
Copy Markdown

High Level Overview of Change

This change set retires the Clawback amendment. All tests were updated to work correctly against retirement.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.4%. Comparing base (2f3558c) to head (4489d53).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7353     +/-   ##
=========================================
- Coverage     82.4%   82.4%   -0.0%     
=========================================
  Files         1011    1011             
  Lines        76477   76475      -2     
  Branches      7322    7315      -7     
=========================================
- Hits         63005   62998      -7     
- Misses       13472   13477      +5     
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
...lude/xrpl/protocol_autogen/transactions/Clawback.h 100.0% <ø> (ø)
src/libxrpl/tx/transactors/account/AccountSet.cpp 98.5% <100.0%> (-<0.1%) ⬇️
src/xrpld/rpc/handlers/account/AccountInfo.cpp 85.3% <100.0%> (-0.1%) ⬇️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant