Skip to content

fix: Fix Audit/Attackathon reports second#7334

Open
gregtatcam wants to merge 5 commits into
developfrom
gregtatcam/mpt/audit-attackathon-fixes-1
Open

fix: Fix Audit/Attackathon reports second#7334
gregtatcam wants to merge 5 commits into
developfrom
gregtatcam/mpt/audit-attackathon-fixes-1

Conversation

@gregtatcam
Copy link
Copy Markdown
Collaborator

@gregtatcam gregtatcam commented May 27, 2026

High Level Overview of Change

Fix audit and attackathon issues (second installation):

  • book_offers rpc reports inflated mpt liquidity using legacy iou funding and transfer-rate semantics
  • missing type tags in cross-type book hashing aliases in getBookBase()

Test Plan

Extend:

OfferMPT_test

Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

@gregtatcam gregtatcam changed the title Fix: Fix Audit/Attackathon reports second fix: Fix Audit/Attackathon reports second May 27, 2026
Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

@gregtatcam gregtatcam force-pushed the gregtatcam/mpt/audit-attackathon-fixes-1 branch from 24f3b17 to 77d5cea Compare May 27, 2026 16:25
Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

@gregtatcam gregtatcam force-pushed the gregtatcam/mpt/audit-attackathon-fixes-1 branch from d4431dd to b2a0a2b Compare May 27, 2026 16:47
Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — no concerns with these fixes.

Review by Claude Opus 4.6 · Prompt: V15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant