Skip to content

feat: XLS-68: Sponsor#5887

Closed
tequdev wants to merge 289 commits into
XRPLF:developfrom
tequdev:sponsor
Closed

feat: XLS-68: Sponsor#5887
tequdev wants to merge 289 commits into
XRPLF:developfrom
tequdev:sponsor

Conversation

@tequdev
Copy link
Copy Markdown
Member

@tequdev tequdev commented Oct 14, 2025

High Level Overview of Change

Context of Change

Type of Change

  • New feature (non-breaking change which adds functionality)

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

tequdev and others added 30 commits September 24, 2025 13:42
- Restructures `STTx` signature checking code to be able to handle
  a `sigObject`, which may be the full transaction, or may be an object
  field containing a separate signature. Either way, the `sigObject` can
  be a single- or multi-sign signature.
- This is distinct from 550f90a (XRPLF#5594), which changed the check in
  Transactor, which validates whether a given account is allowed to sign
  for the given transaction. This cryptographically checks the signature
  validity.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@godexsoft
Copy link
Copy Markdown
Contributor

We recently merged a refactor to develop that enables clang-tidy's readability-identifier-naming. Your branch now has heavy conflicts that are largely mechanical. Below is a workflow that aligns your branch's naming with develop before merging, which should minimize the merge conflicts.

One-time setup

If you don't already have clang-tidy working in your env, on macOS:

brew install llvm@21
# Follow brew's hint to put $(brew --prefix llvm@21)/bin on PATH so run-clang-tidy is found.

Workflow on your branch (before merging develop)

1. Grab the new .clang-tidy from develop without pulling anything else. Sync your fork on GitHub first, then:

git remote -v   # should show 'upstream' among others; if not:
# git remote set-url upstream git@github.com:XRPLF/rippled.git
git fetch upstream
git checkout upstream/develop -- .clang-tidy

2. Reconfigure conan/cmake so compile_commands.json is fresh.

3. Apply renames for the files modified in your PR:

git diff --name-only $(git merge-base HEAD upstream/develop) HEAD \
  | grep -E '\.(cpp|h|hpp|ipp)$' \
  | xargs run-clang-tidy -p build -fix -allow-no-checks
# or -p .build, or whatever your build dir is called

4. Build + test, then commit as a single dedicated commit:

cmake --build build -j8
git commit -am "refactor: Align identifier naming with develop"

5. Now merge develop:

git merge upstream/develop

Extra

Run clang-tidy once more after the merge to catch any stragglers introduced from develop's side:

run-clang-tidy -p build -fix -allow-no-checks src tests
# or -p .build, or whatever your build dir is called

@oleks-rip
Copy link
Copy Markdown
Collaborator

I thought that asserts I added should be converted to throw, to not to continue with errors. Please check fix PR

@tequdev tequdev force-pushed the sponsor branch 2 times, most recently from 3be6dd1 to d21be67 Compare May 6, 2026 06:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@mvadari
Copy link
Copy Markdown
Collaborator

mvadari commented May 28, 2026

Closing in favor of #7350

@mvadari mvadari closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Amendment Blocked: Needs Final XLS The corresponding final XLS must have been merged before this PR is merged. PR: has conflicts QE test required RippleX QE Team must look at this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants