Skip to content

chore: Rewrite verify-commits script#3086

Merged
mathbunnyru merged 2 commits into
XRPLF:developfrom
mathbunnyru:better_verify_script
May 28, 2026
Merged

chore: Rewrite verify-commits script#3086
mathbunnyru merged 2 commits into
XRPLF:developfrom
mathbunnyru:better_verify_script

Conversation

@mathbunnyru
Copy link
Copy Markdown
Collaborator

  1. More clear comments and removed comments that didn't add value
  2. Better function names
  3. git describe --exact-match --tags HEAD will work for both annotated tag and lightweight
  4. Empty version was silently ok
  5. No :
  6. No return 0, so all code looks more uniform

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rewrites the pre-push pre-commit hook that enforces signed release commits and annotated/signed tags, aiming for clearer output and stricter validation around tagging.

Changes:

  • Updated hook messaging and removed no-op : branches / explicit return 0 usage.
  • Split tag checks into clearer functions (annotated vs signed) and added an explicit “no tag at HEAD” failure.
  • Adjusted release-branch detection and release output formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pre-commit-hooks/verify-commits.sh Outdated
Comment thread pre-commit-hooks/verify-commits.sh Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread pre-commit-hooks/verify-commits.sh
Comment thread pre-commit-hooks/verify-commits.sh
Comment thread pre-commit-hooks/verify-commits.sh
@mathbunnyru mathbunnyru merged commit 16c0a64 into XRPLF:develop May 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants