Set default ee_policy to allow certificates with any keyUsage#293
Closed
U-238 wants to merge 4 commits into
Closed
Set default ee_policy to allow certificates with any keyUsage#293U-238 wants to merge 4 commits into
U-238 wants to merge 4 commits into
Conversation
… key usage, and allow overriding of EE and CA validation policies.
…eyUsage extensions
Contributor
Author
|
This PR also fixes the type hints for the |
Member
|
Hmm, relaxing to no requirement at all also seems wrong. I think what you originally proposed is the right thing to do. I decided to go ahead and migrate to your originally proposed behavior, requiring digital signature key usage by default, documenting an escape hatch, and fixing up the tests to use the permissive policy for legacy test cases. Thanks for pushing on this. Let me know if anything else about the API doesn't make sense and I'm happy to work with you to update it. Released in v5.0.0, please test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webpki_defaults_ee()still requires a certificate to have the "TLS Web Client Authentication" extended key usage, which should not be required for signing XML documents.This PR changes the default to
permit_all(), which will allow documents to be signed using any certificate regardless of key usage extensions specified in the certificate.