Skip to content

Set default ee_policy to allow certificates with any keyUsage#293

Closed
U-238 wants to merge 4 commits into
XML-Security:mainfrom
U-238:main
Closed

Set default ee_policy to allow certificates with any keyUsage#293
U-238 wants to merge 4 commits into
XML-Security:mainfrom
U-238:main

Conversation

@U-238

@U-238 U-238 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

webpki_defaults_ee() still requires a certificate to have the "TLS Web Client Authentication" extended key usage, which should not be required for signing XML documents.

This PR changes the default to permit_all(), which will allow documents to be signed using any certificate regardless of key usage extensions specified in the certificate.

@U-238

U-238 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

This PR also fixes the type hints for the ee_policy and ca_policy arguments

@kislyuk

kislyuk commented Jun 21, 2026

Copy link
Copy Markdown
Member

Hmm, relaxing to no requirement at all also seems wrong. I think what you originally proposed is the right thing to do.

I decided to go ahead and migrate to your originally proposed behavior, requiring digital signature key usage by default, documenting an escape hatch, and fixing up the tests to use the permissive policy for legacy test cases.

Thanks for pushing on this. Let me know if anything else about the API doesn't make sense and I'm happy to work with you to update it.

Released in v5.0.0, please test.

@kislyuk kislyuk closed this Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants