Refactor usfm fixer module#320
Merged
linearcombination merged 2 commits intoJul 2, 2026
Merged
Conversation
Better setup leading to leaner main logic
PurpleGuitar
reviewed
Jul 1, 2026
|
|
||
| if ( | ||
| not re.compile(r"""\\v \d+""").search(context_for_standalone_verse) | ||
| not compiled_patterns["fix_standalone_verse_numbers"].search( |
Contributor
There was a problem hiding this comment.
The new "fix_standalone_verse_numbers" pattern is very different than the old one:
not re.compile(r"""\\v \d+""").search(context_for_standalone_verse)Is this intentional? It seems like it would have very different behavior.
Contributor
Author
There was a problem hiding this comment.
Thanks, I will take a closer look just in case. AI guided refactor warning. All tests passed, but I will make sure that case is covered. Appreciate you checking.
Contributor
Author
There was a problem hiding this comment.
Ok, I relaxed a few changes to retain the original intent. Ready for re-review
Restore a couple search regex patterns from prior version
linearcombination
merged commit 21f7cfa
into
WycliffeAssociates:doc-dev.walink.org
8 checks passed
github-project-automation
Bot
moved this from In progress
to Done
in DOC Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better setup leading to leaner main logic