Various updates DOC, STET, Passages#319
Merged
PurpleGuitar merged 17 commits intoJun 30, 2026
Merged
Conversation
Prior to this commit, ulb was always preferred for any language. We learned that at least one language, fr, should prefer non-ulb usfm text if available. This change makes it possible to specify additional languages besides fr that may need the same treatment.
A test with fr, f10, revealed that its chapter source was not being properly split into verses because of the extra markup formatting that is in f10. This commit switches to using BeautifulSoup to ensure proper matching of nested beginning and ending tags so that chapters are properly split into discrete verses. It may be more robust for other languages that we have not tested yet too which also have similar markup characteristics.
We already have disabled rg from the ui by request of the PO, but here is a place where it was still potentially being used in the consideration of what books to consider available for a particular language.
Only STET uses it
Add gu, ru, and bulgarian. Note that ru does not provide NT books, only OT books, so it has no utility in STET where all references are to NT. Thus ru is filtered out of the list of source languages currently displayed by STET.
Underline and black. Have not added the highlight desired yet as it is quite tricky to achieve and may not be desirable since it will gobble toner.
More iteration to come possibly.
linearcombination
force-pushed
the
various-updates-stet-passages-doc
branch
from
01154fa to
2a865b9
Compare
PurpleGuitar
approved these changes
Jun 22, 2026
linearcombination
changed the base branch from
doc.bibleineverylanguage.org
to
doc-dev.walink.org
Prefer defaulted function parameters for referential transparency. From this view, stylistically, they function as dependency injection.
- Was able to unify the fr and non-fr cases to one function for DOC. - Deemed it worthwhile to abandon DRY to let STET and Passages have their own version of same to allow for future differentiation as needed and not have to cross reference to DOC as much for API support. This is grey area when it comes to design, but I think it makes sense in this case. - Some cleanup and move to use BeautifulSoup a bit more than regex to ensure tag end matching.
Contributor
Author
|
Thanks for the very helpful review. I've made changes related to your feedback and also others that improve things. Can you please rereview? |
PurpleGuitar
approved these changes
Jun 30, 2026
PurpleGuitar
merged commit cafe8ce
into
WycliffeAssociates:doc-dev.walink.org
8 checks passed
github-project-automation
Bot
moved this from In progress
to Done
in DOC Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text if available. This change makes it possible to specify additional
languages besides fr that may need the same treatment.
properly split into verses because of the extra markup formatting that
is in f10. This is now more robust.
is a place where it was still potentially being used in the
consideration of what books to deem available for a particular
language. We removed that.