Front end test fixes#318
Merged
Merged
Conversation
Fix Ontenu resource type name
Increase timeout for button and text interactions
There was a problem hiding this comment.
Pull request overview
This PR updates a Playwright E2E flow to be less flaky by adding explicit waits/timeouts around “Next” transitions and resource selection when generating a Prince PDF with a larger book set.
Changes:
- Add explicit waits for the “Next” button to become enabled before continuing through the wizard.
- Increase/explicitly set timeouts around resource selection steps (e.g., Unlocked Literal Bible / Regular).
- Adjust the resource-selection steps to match the expected UI flow (ULB + Regular).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+42
to
43
| await expect(page.getByRole('button', { name: 'Next' })).toBeEnabled({ timeout: 15_000 }) | ||
| await page.getByRole('button', { name: 'Next' }).click() |
Comment on lines
+47
to
48
| await expect(page.getByRole('button', { name: 'Next' })).toBeEnabled({ timeout: 15_000 }) | ||
| await page.getByRole('button', { name: 'Next' }).click() |
Comment on lines
+51
to
52
| await expect(page.getByRole('button', { name: 'Next' })).toBeEnabled({ timeout: 60_000 }) | ||
| await page.getByRole('button', { name: 'Next' }).click() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.