Skip to content

Increase timeout for button and text interactions #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurpleGuitar merged 1 commit into from
Jun 18, 2026
Merged

Increase timeout for button and text interactions #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions frontend/tests/e2e/doc_test_4.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,16 @@ test('use prince with lots of books', async ({ page }) => {
await page.getByPlaceholder('Search Heart Languages').click()
await page.getByPlaceholder('Search Heart Languages').fill('ont')
await page.getByText('Ontenu').click()
await expect(page.getByRole('button', { name: 'Next' })).toBeEnabled({ timeout: 15_000 })
await page.getByRole('button', { name: 'Next' }).click()
await page.getByText('Select all').click()
await page.getByRole('button', { name: 'Old Testament' }).click()
await page.getByRole('button', { name: 'New Testament' }).click()
await expect(page.getByRole('button', { name: 'Next' })).toBeEnabled({ timeout: 15_000 })
await page.getByRole('button', { name: 'Next' }).click()
await page.getByText('Unlocked Literal Bible').first().click()
await page.getByText('Unlocked Literal Bible').nth(1).click()
await page.getByText('Unlocked Literal Bible').first().click({ timeout: 120_000 })

@PurpleGuitar PurpleGuitar Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "Regular" too?

@danparisd danparisd Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's the Tok Pisin resource, and it is ULB. This line was only changed to add the timeout. These timeouts are added to make it fail faster if something is amiss.

await page.getByText('Regular').click({ timeout: 30_000 })
await expect(page.getByRole('button', { name: 'Next' })).toBeEnabled({ timeout: 60_000 })
await page.getByRole('button', { name: 'Next' }).click()
await page.getByRole('radio', { name: 'PDF' }).click()
await page.getByText('Interleave content by chapter').click()
Expand Down
Loading