Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 363decc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25413058813
|
422119d to
363decc
Compare
|
I just rebased this PR - if things pass I'll merge it today since the CI is blocked for others. Cheers! |
What?
This PR is part of a couple related PRs for fixing a sync issue in RTC:
We should be able to merge the Gutenberg PR, but because core replaces the
WP_HTTP_Polling_Sync_Serverclass, the changes in that PR won't actually be running in tests. Once the backport merges, it will, and then thetest_sync_stale_compaction_succeeds_when_newer_compaction_exists()test will start failing.Note that the fixed unit test in this PR is expected to fail until the backport is merged.
Why?
So we can fix failing unit tests once the backport PR is merged.
How?
This PR updates the unit test
test_sync_stale_compaction_succeeds_when_newer_compaction_exists()to match the new server-side logic which allows multiple compaction results to be processed.Testing Instructions
Tests can also be run locally via: