test(dash): improve update_service tests#84
Merged
Conversation
- Move import json to module top level - Strengthen mock empty-payload test with original_name capture - Add assert original_name != changed value in partial update test - Add assert len(responses.calls) == 1 in fallback test - Add 3 new tests: 500 error, GET 404 on empty payload, GET network error on empty payload Total: 103 tests, all passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改进内容
基于 reviewer 反馈改进 dash 的 update_service 测试：
import json从函数内部移到模块顶部所有 103 个测试通过。