WI01073344 - .NET 10 fixing - Group 12A - DataGrid selection state fix#18
Open
Rick-Xu-WTG wants to merge 1 commit into
Open
WI01073344 - .NET 10 fixing - Group 12A - DataGrid selection state fix#18Rick-Xu-WTG wants to merge 1 commit into
Rick-Xu-WTG wants to merge 1 commit into
Conversation
…uring row recreation (.NET 10 fix) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix DataGrid row selection state loss during row recreation in .NET 10.
Problem
When upgrading from .NET 8 to .NET 10, DataGrid's internal row recreation cycle destroys row objects, causing all selection state to be lost. This breaks 10+ tests in CargoWise1 PR #50917 (Group 12A).
Root Cause
.NET 10 triggers
SetDataGridRows()which callsResetUIState()→ clears row-level selection → rows get recreated as new objects. The old selection state is destroyed with the old row objects.Fix
Added
HashSet<int> _selectedRowCachefield that maintains selection state independently of DataGrid's internal row arrays:Select(row): stores row index in cacheIsSelected(row): falls back to cache when row array is empty/mismatchedUnSelect(row): removes from cacheResetSelection(): intentionally does NOT clear cache (survives row recreation)SetDataGridRows(): re-applies cached selections to new row objects after recreationTesting
Changed File
src/System.Windows.Forms/System/Windows/Forms/Controls/Unsupported/DataGrid/DataGrid.cs