Harden issue PR publication reliability - #435
Open
Wibias wants to merge 15 commits into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the publication-reliability defects reproduced by the full Grok commit + PR trace:
ghsubprocesses remain colourless even when the parent environment forces ANSI/TTY output;OPEN_PRstill requires the locked push and create-PR receipts.Regression evidence
RED-first coverage reproduced the publication gaps. The later Node 22 regression was traced to older tests that bypassed the new publication-plan boundary; those tests now construct the required locked plan instead of weakening production enforcement.
Verification
Exact head:
b38a1d8c59d3623b28ec88d40c993d14a891effbScope
Publication reliability only. Evidence integrity, controller state grounding, and trace diagnostics are isolated in #434, #436, and #437.
Ready for review. Do not merge without explicit instruction.