Skip to content

fix(deps): bump js-yaml override to 4.3.1 (clears the last open Dependabot alert, GHSA-5p4m-2wfm-xmqj) #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logbie merged 2 commits into from
Aug 14, 2026
Merged

fix(deps): bump js-yaml override to 4.3.1 (clears the last open Dependabot alert, GHSA-5p4m-2wfm-xmqj) #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d07526f
fix(deps): bump js-yaml override to 4.3.1 to clear GHSA-5p4m-2wfm-xmqj
logbie Aug 14, 2026
fe9c8a1
Merge branch 'main' into warden/bump-js-yaml-4.3.1
logbie Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vscode-extension/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vscode-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
"@vscode/test-electron": "^2.5.2"
},
"overrides": {
"js-yaml": "4.3.0",
"js-yaml": "4.3.1",

@devin-ai-integration devin-ai-integration Bot Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lockfile root entry carries no overrides metadata, so the pin may not be reproducible via npm ci

The lockfile change (vscode-extension/package-lock.json:1909-1912) only edits the node_modules/js-yaml version/resolved/integrity triple, matching the previous 4.3.0 pin commit. However, the lockfile's root package entry (packages[""]) contains no overrides object, even though vscode-extension/package.json:176-179 declares overrides for js-yaml and serialize-javascript. npm normally records the resolved overrides block in the lockfile root when regenerating, and uses it to detect drift between package.json and the lock. Its absence suggests the lock was hand-edited rather than produced by npm install --package-lock-only, which could make npm ci reject or silently re-resolve the tree. Worth verifying by actually running npm install --package-lock-only && npm ci once CI is unblocked (per the PR description, CI currently cannot run).

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"serialize-javascript": "7.0.6"
}
}
Loading