[WIP] Don't use menubuttons where we don't want buttons#411
Open
trigg wants to merge 13 commits into
Open
Conversation
panel: start standardising on popups
panel: fix popup too big for screen
panel: fix menu crash before init panel: made menu-follows-mouse an option
panel: widgets can optionally have fullscreen popover panel: merged popover classes panel: window-list stop using button
Collaborator
Author
|
From my daily testing this is now in place. BUT the change from button to box/image whatever internals has changed some of the extra padding added by button. The panel is more compact again, especially around menu button. |
background: remove keyboard on_demand
panel: account for smaller widget size now we have removed buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor internal WayfireMenuButton to no longer actually be a menu button
MenuButton was originally chosen as it was the only way I had found to make a popover-menu for panel widgets.
We put a fair bit of extra code to make MenuButton not actually be a menubutton. So this PR will standardise an interface for all Popup-based widgets without each one having to fight to not look like a button
Advantages over not having this PR:
Currently timed-popups are suffering a bug where only one of the popups show and leaves other panels in an undefined state, very very similar to below
https://gitlab.gnome.org/GNOME/gtk/-/issues/6465
Because of the above, thorough testing on a multi-head system is required before merging