ci: drop the #312 transition guards and v1 cache fallbacks

[EricAndrechek]

Summary

Post-merge cleanup for #312 — removes the transition scaffolding it carried, now that it's landed on main.

• ci.yml — the PR title and docs-preview-comment steps no longer guard on scripts/ci/{check-pr-title,docs-preview-comment}.sh existing (the if [ ! -f … ]; then … exit 0; fi skip-with-notice). Both scripts are on main now, so the steps call them directly. Confirmed present on origin/main (the trusted-main checkout these steps use).
• .github/actions/setup-env/action.yml — drops the two unversioned v1 gobuild- restore-key fallbacks, keeping the gobuild-v2-* ones. Verified gobuild-v2-* caches exist for every suffix (-lint/-unit/-integration/-e2e-cov/-cov) on main, so no cold-cache regression.
• .github/workflows/README.md — removes the "Transition notes" section and the cache-table v1 TODO.

The ruleset flip (done out-of-band)

The fourth transition item — the merge-queue ruleset flip — was applied directly via the API (it's a branch-protection change, not a code change). The main branch protection ruleset now has:

• the merge_queue rule (SQUASH, ALLGREEN grouping, min_entries_to_merge: 1, up to 5 speculative builds), and
• strict_required_status_checks_policy: false (drops the "require branches up to date" requirement — the merge queue's integration re-test replaces it).

So this PR will itself land through the merge queue ("Merge when ready").

Test plan

• actionlint + markdownlint + shellcheck clean (make lint-gha lint-md lint-sh)
• make ci green locally
• de-guarded scripts confirmed present + executable on origin/main (git cat-file -e origin/main:scripts/ci/check-pr-title.sh)
• gobuild-v2-* caches confirmed present for every suffix on main (no cold-cache regression from dropping v1)
• no dangling references to the removed guards / Transition-notes section anywhere in the tree

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 362dd43e-d383-4fe8-95d0-15113ea85a10

📥 Commits

Reviewing files that changed from the base of the PR and between 9bc9a42 and 2c4585d.

📒 Files selected for processing (3)

• .github/actions/setup-env/action.yml
• .github/workflows/README.md
• .github/workflows/ci.yml

📜 Recent review details

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Integration tests
• GitHub Check: Coverage
• GitHub Check: Unit tests
• GitHub Check: E2E tests
• GitHub Check: Docs build

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-06-10T15:01:59.729Z

Learnt from: EricAndrechek
Repo: Wave-RF/WaveHouse PR: 312
File: .github/workflows/ci.yml:232-237
Timestamp: 2026-06-10T15:01:59.729Z
Learning: In this repo’s CI workflow (ci.yml), treat `clickhouse/clickhouse-server:latest` in the workflow’s prefetch steps (`docker pull -q clickhouse/clickhouse-server:latest`) as an intentional canary: the `:latest` tag is meant to mirror the tag that testcontainers resolves at runtime. Do not flag it as a supply-chain concern during CI workflow reviews as long as it’s used specifically for this “latest mirrors testcontainers runtime” prefetch purpose. If the workflow pins a different tag/digest for a different reason, or uses `latest` outside of this prefetch/canary pattern, then it may warrant scrutiny.

Applied to files:

• .github/workflows/ci.yml

🔇 Additional comments (4)

.github/actions/setup-env/action.yml (1)

90-97: LGTM!

.github/workflows/ci.yml (2)

110-116: LGTM!

---

491-500: LGTM!

.github/workflows/README.md (1)

154-157: LGTM!

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Optimized Go module and build cache restore behavior in the CI/CD pipeline for improved build efficiency and faster cache restoration.
  • Streamlined PR title validation and documentation preview workflows by removing transitional guards and simplifying script handling.
  • Cleaned up CI/CD configuration and documentation by removing obsolete transition notes.

Walkthrough

This PR completes a CI cache and script versioning rollout by removing legacy v1 cache restore-key fallbacks, eliminating transitional script-existence guards from the workflow, and cleaning up related transition documentation notes that are no longer needed.

Changes

CI Transition Rollout Completion

Layer / File(s)	Summary
Go cache versioning finalization ​.github/actions/setup-env/action.yml	The gobuild-* v1 unversioned restore-key prefixes are removed from the cache step; only gobuild-v2-* same-suffix and bare fallback restore keys remain.
Script execution guard removal ​.github/workflows/ci.yml	PR title validation and docs-preview comment steps now invoke their scripts directly instead of using conditional guards that skipped execution when scripts weren't present on the default branch.
Transition documentation cleanup ​.github/workflows/README.md	The "Cache inventory" cache entry is updated to remove the TODO note about v1 restore-keys, and the entire "Transition notes (delete when done)" section with rollout checklist items is deleted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

documentation, area/docs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removing transition guards and v1 cache fallbacks from CI configuration, which accurately reflects the primary focus of the changeset.
Description check	✅ Passed	The description is well-related to the changeset, providing detailed explanations of changes to ci.yml, setup-env/action.yml, and README.md, along with a comprehensive test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci-postmerge-cleanup

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch ci-postmerge-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📚 Docs preview is live → https://fc958e9b-wavehouse-docs.wave-rf.workers.dev

• Commit — 2c4585d: ci: drop the ci: split ci into a job dag and isolate docs deploys from pr code #312 transition guards and v1 cache fallbacks
• Author — @EricAndrechek, Claude Opus 4.8 (1M context)
• Committed — 2026-06-10 16:15 (UTC-04:00)
• Deployed — 2026-06-10 16:32 EDT