Implemented/Fixed Mine Door rotation by KSunyo · Pull Request #58 · Warlander/DeedPlanner-3

KSunyo · 2026-01-25T10:17:08Z

Created a new enum called DoorDirection
Added a new property to GroundData.cs called IsCaveDoor as the main condition for rotation related methods
- I check if ShortName matches any predefined String.
Added DoorDirection public property in Ground.cs, which is by default DoorDirection.N, and added it to the ground constructor and to other methods as parameter.
Added doorDirectionsArray in GroundMesh.cs.
Added UpdateDoorDirection method being responsible of calculating the relevant orientation and RefreshDoorOrientation method which is called in the Refresh method.
Added ApplyUvRotation method in GroundMesh.cs, that when a rotation is applicable manipulates the meshUVs.
Extended SetGroundData in GroundMesh.cs.

This PR is related to issue #7 .

Issue Warlander/DeedPlanner3 Warlander#7

This reverts commit d4f1512.

Warlander

I think door direction rotation should be happening on graphics level only, without Ground model needing to be aware of it as we only really need it for rendering - and it shouldn't be a performance issue given we only need this info if something is changing with the ground.

Warlander · 2026-01-25T17:26:28Z

                    ground.data = newData;
-                    ground.Tile.Map.Ground.SetGroundData(ground.Tile.X, ground.Tile.Y, ground.data, ground.RoadDirection);
+                    ground.DoorDirection = ground.Tile.UpdateDoorDirection();
+                    ground.Tile.Map.Ground.SetGroundData(ground.Tile.X, ground.Tile.Y, ground.data, ground.RoadDirection, ground.DoorDirection);


Why do we need to serialize it?

It's not serialized anymore

Warlander · 2026-01-27T05:13:30Z

            Tex2d = tex2d;
            Tex3d = tex3d;
            Diagonal = diagonal;
+            IsCaveDoor = ShortName is "wcaDoor" or "gcaDoor" or "scaDoor" or "mcaDoor";


I would lean more towards optional XML tag here, similar to how openings and diagonal-enabled ground types are defined.

As cave doors are the only ground types that can rotate, I used the "Cave door" category name to set it to true

I think using the category name is a better way to check this as it is already documented in objects.xml whether it is a cave door or not, and this way we require no extra tag.

Warlander · 2026-01-27T05:15:30Z

            // Cave.Initialize(this, Database.DefaultCaveData);
        }
+
+        public DoorDirection UpdateDoorDirection()


Update would indicate something within the tile changes but it's not the case, the door direction seems to be calculated here.

Renamed it to CalculateDoorOrientation

Warlander · 2026-01-27T05:17:46Z

+            // Rotating vectors based on DoorDirection
+            if (dir == DoorDirection.E)
+            {
+                (v00, v10, v11, v01) = (v10, v11, v01, v00);


That's interesting syntax, honestly it makes lots of sense here! 👀

Warlander · 2026-01-27T05:21:46Z

+            DoorDirection doorDir = doorDirectionsArray[x, y];
            Vector2Int selfCoords = new Vector2Int(x, y);

+            int westSlot = vertexIndex;


I think syntax where these values are only initialized once would be easier to read here.

In the newest commit I changed it a bit:

var (wOffset, nOffset, eOffset, sOffset) = (data.IsCaveDoor ? doorOrientation : DoorOrientation.N) switch
{
DoorOrientation.E => (9, 0, 3, 6),
DoorOrientation.S => (6, 9, 0, 3),
DoorOrientation.W => (3, 6, 9, 0),
_ => (0, 3, 6, 9),
};
int westSlot = vertexIndex + wOffset;
int northSlot = vertexIndex + nOffset;
int eastSlot = vertexIndex + eOffset;
int southSlot = vertexIndex + sOffset;

Warlander · 2026-01-27T05:23:23Z

        private int[,] slopesArray;
        private GroundData[,] dataArray;
        private RoadDirection[,] directionsArray;
+        private DoorDirection[,] doorDirectionsArray;


Just as a sanity check, is it guaranteed to be correct initially? All door directions will be set to N by default.

For cave doors it is guaranteed to be incorrect almost always initially. But then it should almost immediately correct itself as of the current version.

Warlander · 2026-01-27T05:24:18Z

        private bool needsUvUpdate = false;

-        public void Initialize(int width, int height, OverlayMesh newOverlayMesh)
+        public void Initialize(Map map, int width, int height, OverlayMesh newOverlayMesh)


I'm not a fan of map knowing about GroundMesh and GroundMesh about the map, but this entire part of code needs later refactor anyway so I'm ok with it for now.

This should not be a problem now, groundMesh just gets the orientation, doesn't initiate calculating it.

Ground.cs: New CalculateOrientationFor method using Tile.CalculateDoorOrientation, method is being used in setting orientation into ground data. Also added old/new state switches to execute, undo GroundMesh.cs Pretty much same as was before, I just had to re-add it after merge conflict overwrite. Except GroundMesh now doesn't know about map.cs TIle.cs Calculate orientation inside refreshorientation method now, rather than calculating it at groundMesh, so now when it is called in ground this both calculates it and sets it into groundData.

Warlander · 2026-08-28T22:12:34Z

                            break;
                        case "category":
                            categories.Add(child.InnerText.Split('/'));
+                            caveDoor = (child.InnerText == "Cave doors") ? true : false;


Project convention is to use XML tags for this kind of data - check "diagonal" for example. :)

Warlander · 2026-08-28T22:17:14Z

+            meshUvs[vertexIndex + 10] = v00;
+            meshUvs[vertexIndex + 11] = vCenter;
+
+            RenderMesh.uv = meshUvs;


This is an expensive call, but we already have needsUvUpdate flag to make sure it gets triggered once per frame at most

Warlander · 2026-08-28T22:20:07Z

-                tile.Map.GetRelativeTile(tile, -1, 0)?.RefreshSurfaceEntities();
-                tile.Map.GetRelativeTile(tile, 0, -1)?.RefreshSurfaceEntities();
-                tile.Map.GetRelativeTile(tile, -1, -1)?.RefreshSurfaceEntities();
+                t10?.RefreshSurfaceEntities();


Is there something about this change that requires refreshing surface entities on nearby tiles?

I believe this is actually not changed just added the Tile variables. Before the PR it looked like this:
tile.RefreshSurfaceEntities(); tile.Map.GetRelativeTile(tile, -1, 0)?.RefreshSurfaceEntities(); tile.Map.GetRelativeTile(tile, 0, -1)?.RefreshSurfaceEntities(); tile.Map.GetRelativeTile(tile, -1, -1)?.RefreshSurfaceEntities();

I would assume this is to set walls and fences properly on neighboring tiles when the slope changes.

Warlander · 2026-08-28T23:44:15Z

                {
                    ground.data = oldData;
-                    ground.Tile.Map.Ground.SetGroundData(ground.Tile.X, ground.Tile.Y, ground.data, ground.RoadDirection);
+                    DoorOrientation orientation = CalculateOrientationFor(ground, newData);


Should we pass new data in undo? May be worth testing if that's the correct behavior

Thanks for catching this, this should definitely be oldData 😅

Implemented Mine Door rotation

673ea58

Issue Warlander/DeedPlanner3 Warlander#7

KSunyo linked an issue Jan 25, 2026 that may be closed by this pull request

Mine Doors flipped and flipped. #7

Open

KSunyo added bug Something isn't working enhancement New feature or request labels Jan 25, 2026

KSunyo added 3 commits January 26, 2026 09:03

Merge remote-tracking branch 'upstream/master'

833b4ee

Updated objects.xml with correct logWideWindow mesh name

d4f1512

Revert "Updated objects.xml with correct logWideWindow mesh name"

39f3825

This reverts commit d4f1512.

Warlander requested changes Jan 26, 2026

View reviewed changes

KSunyo added 4 commits January 27, 2026 03:40

Merge remote-tracking branch 'upstream/master'

d3abba3

Refactored DoorDirection logic

20f75c4

Added null check to SetGroundData for currenTile

98e0008

Optimisation to SetGroundData method

beb7472

KSunyo requested a review from Warlander January 27, 2026 04:09

Warlander requested changes Jan 27, 2026

View reviewed changes

KSunyo added 9 commits January 27, 2026 09:47

Renamed and refactored Door Orientation logic

8654b67

Minor changes to Ground.cs and Groundmesh.cs

8a6d39d

Merge remote-tracking branch 'upstream/master'

5fbccda

Merge remote-tracking branch 'upstream/master'

b29add4

Merge remote-tracking branch 'upstream/master'

2a71dce

Merge remote-tracking branch 'upstream/master'

31979f7

Merge remote-tracking branch 'upstream/master'

5f56451

Merge remote-tracking branch 'upstream/master'

ac3ae1f

KSunyo self-assigned this Aug 28, 2026

Fixed Mine doors not rotating next to map edge

0641615

KSunyo requested a review from Warlander August 28, 2026 21:00

Warlander requested changes Aug 28, 2026

View reviewed changes

Uh oh!

Conversation

KSunyo commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Warlander left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KSunyo Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KSunyo commented Jan 25, 2026 •

edited

Loading

KSunyo Jan 27, 2026 •

edited

Loading