-
-
Notifications
You must be signed in to change notification settings - Fork 17
fix: playlist loaders, audio player a11y #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dbb301d
fix: playlist loaders, audio player a11y
WINOFFRG d14a89e
fixed AI issues and missing animation
WINOFFRG 2cb7a18
fix: playlist repeat issue
WINOFFRG a082448
fix: build errors and toggle group
WINOFFRG f7ec6f6
fix: build errors and toggle group
WINOFFRG 441bcaa
fix: build errors and toggle group
WINOFFRG 974f8f7
fix: baseui and radix conflict in toggle
WINOFFRG 8295ce4
fix: audio player - playlist offset bui/rui incomat
WINOFFRG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Development | ||
|
|
||
| This repo uses Bun workspaces. The docs site and registry live in `apps/www`. | ||
|
|
||
| ## Setup | ||
|
|
||
| ```bash | ||
| bun install | ||
| cd apps/www | ||
| bun run dev | ||
| ``` | ||
|
|
||
| The local site runs on the Next.js dev server. | ||
|
|
||
| ## Commands | ||
|
|
||
| Run these from the repo root unless the command says otherwise. | ||
|
|
||
| ```bash | ||
| bun run lint | ||
| bun run format:check | ||
| bun run test:local | ||
| ``` | ||
|
|
||
| Registry and site checks: | ||
|
|
||
| ```bash | ||
| cd apps/www | ||
| bun run registry:build | ||
| bun run validate:registries | ||
| bun run build | ||
| ``` | ||
|
|
||
| ## Project Layout | ||
|
|
||
| | Path | Purpose | | ||
| | --- | --- | | ||
| | `apps/www/content/docs` | Fumadocs documentation | | ||
| | `apps/www/registry/default/ui` | Copyable UI primitives | | ||
| | `apps/www/registry/default/hooks` | Feature hooks and utilities | | ||
| | `apps/www/registry/default/blocks` | Complete player blocks | | ||
| | `apps/www/registry/collection` | shadcn registry metadata | | ||
| | `apps/www/public/r` | Generated registry JSON | | ||
| | `prompts` | Project rules for local assistants and review tooling | | ||
|
|
||
| ## Contribution Notes | ||
|
|
||
| - Public examples should import from `@/components/limeplay/*` and `@/hooks/limeplay/*`, not `@/registry/*`. | ||
| - New or changed components, hooks, and utilities need registry metadata. | ||
| - Registry dependencies should be explicit and major versions with breaking changes should be pinned. | ||
| - Blocks should keep public loading props consistent: `source`, `loading`, `sourceKey`, `autoLoad`, `initialIndex`, and `mediaProps`. | ||
| - Use feature selectors and `useMediaEvents()` instead of deleted convenience hooks or `on*` callback fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Side effect inside state updater; URL replace can run more than once for a single toggle. Move query-sync side effect outside the updater (e.g., effect driven by
expanded).Prompt for AI agents