Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for filtering Cargo Movements and Cargo Time Series results by “hard data” record source types, and updates the Cargo Movement product schema to expose external source details.
Changes:
- Add
filter_hard_data/exclude_hard_dataparameters to Cargo Movements and Cargo Time Series search requests. - Introduce
CargoMovementRecordSourceTypeand modelproduct.external_sourcesin the Cargo Movement API model. - Extend tests to cover the updated Cargo Movement model and add real-API tests for hard data filtering.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
vortexasdk/endpoints/cargo_timeseries.py |
Adds filter_hard_data / exclude_hard_data request parameters to timeseries search. |
vortexasdk/endpoints/cargo_movements.py |
Adds filter_hard_data / exclude_hard_data request parameters to cargo movements search. |
vortexasdk/api/cargo_movement.py |
Adds record source Literal type + external_sources modeling for cargo movement product entries. |
tests/endpoints/test_cargo_movements_real.py |
Adds real-API tests intended to validate hard data filtering behavior. |
tests/api/test_cargo_movement.py |
Updates the CargoMovement parsing/flattening expectations for the new product schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CookieMonitor
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELATED TICKETS
! Do not post related PRs here, unless they are open source !
CHANGELOG
filter_hard_dataandexclude_hard_datato Cargo Movements search and timeseries to filter over CMs including products with external data sources.TESTS
COMMENTS