Skip to content

chore: add filter hard data to cm search and timeseries#561

Merged
cojdev merged 6 commits intomasterfrom
rnd-20564
Apr 13, 2026
Merged

chore: add filter hard data to cm search and timeseries#561
cojdev merged 6 commits intomasterfrom
rnd-20564

Conversation

@cojdev
Copy link
Copy Markdown
Contributor

@cojdev cojdev commented Apr 13, 2026

RELATED TICKETS

! Do not post related PRs here, unless they are open source !

CHANGELOG

  • add filter_hard_data and exclude_hard_data to Cargo Movements search and timeseries to filter over CMs including products with external data sources.

TESTS

  • describe your test strategy

COMMENTS

  • any other business

Copilot AI review requested due to automatic review settings April 13, 2026 13:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for filtering Cargo Movements and Cargo Time Series results by “hard data” record source types, and updates the Cargo Movement product schema to expose external source details.

Changes:

  • Add filter_hard_data / exclude_hard_data parameters to Cargo Movements and Cargo Time Series search requests.
  • Introduce CargoMovementRecordSourceType and model product.external_sources in the Cargo Movement API model.
  • Extend tests to cover the updated Cargo Movement model and add real-API tests for hard data filtering.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
vortexasdk/endpoints/cargo_timeseries.py Adds filter_hard_data / exclude_hard_data request parameters to timeseries search.
vortexasdk/endpoints/cargo_movements.py Adds filter_hard_data / exclude_hard_data request parameters to cargo movements search.
vortexasdk/api/cargo_movement.py Adds record source Literal type + external_sources modeling for cargo movement product entries.
tests/endpoints/test_cargo_movements_real.py Adds real-API tests intended to validate hard data filtering behavior.
tests/api/test_cargo_movement.py Updates the CargoMovement parsing/flattening expectations for the new product schema.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread vortexasdk/endpoints/cargo_movements.py Outdated
Comment thread vortexasdk/endpoints/cargo_timeseries.py
Comment thread tests/endpoints/test_cargo_movements_real.py
Comment thread tests/api/test_cargo_movement.py
Comment thread tests/endpoints/test_cargo_movements_real.py
cojdev and others added 4 commits April 13, 2026 15:14
@cojdev cojdev merged commit 92f9c99 into master Apr 13, 2026
11 of 12 checks passed
@cojdev cojdev deleted the rnd-20564 branch April 13, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants