Skip to content

test(titlebar): fix TitleBar.syncState flake from cold-transform timeout #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kipavy merged 1 commit into from
Aug 19, 2026
Merged

test(titlebar): fix TitleBar.syncState flake from cold-transform timeout #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/components/layout/TitleBar.syncState.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { describe, test, expect, vi, beforeEach, afterEach } from "vitest";
import { describe, test, expect, vi, beforeAll, beforeEach, afterEach } from "vitest";
import { render, cleanup } from "@testing-library/react";
import { usePluginStateStore } from "@/stores/pluginStateStore";
import { __resetGistSyncStateWarnings } from "@/services/syncStatus";
Expand All @@ -25,6 +25,15 @@ vi.mock("@/utils/icons", () => ({

const PLUGIN_ID = "plugin-gist-sync";

// TitleBar pulls in a large dependency graph that vitest must cold-transform
// on first import. Under load that transform alone can exceed the default
// 5s test timeout, so it's paid once here in beforeAll (unbounded by any
// single test's timeout) rather than inside each test via a per-test import.
let TitleBar: (typeof import("./TitleBar"))["default"];
beforeAll(async () => {
({ default: TitleBar } = await import("./TitleBar"));
}, 20000);

beforeEach(() => {
usePluginStateStore.setState({ values: new Map() });
__resetGistSyncStateWarnings();
Expand All @@ -37,7 +46,7 @@ afterEach(cleanup);
// (root.children dropped to 0). This renders the real TitleBar against that exact
// malformed publish and proves it no longer crashes.
describe("TitleBar + malformed gist-sync state", () => {
test("renders without throwing when lastSync is published as an ISO string", async () => {
test("renders without throwing when lastSync is published as an ISO string", () => {
usePluginStateStore.getState().publish(PLUGIN_ID, "sync-state", {
status: "success",
lastSync: "2026-01-01T00:00:00.000Z",
Expand All @@ -46,11 +55,10 @@ describe("TitleBar + malformed gist-sync state", () => {
configured: true,
});

const { default: TitleBar } = await import("./TitleBar");
expect(() => render(<TitleBar />)).not.toThrow();
});

test("renders without throwing when lastSync is published as unparseable garbage", async () => {
test("renders without throwing when lastSync is published as unparseable garbage", () => {
usePluginStateStore.getState().publish(PLUGIN_ID, "sync-state", {
status: "success",
lastSync: "not-a-date",
Expand All @@ -59,7 +67,6 @@ describe("TitleBar + malformed gist-sync state", () => {
configured: true,
});

const { default: TitleBar } = await import("./TitleBar");
expect(() => render(<TitleBar />)).not.toThrow();
});
});