Harden playtest launcher against non-fatal git pull stderr - #260
Merged
Conversation
Run the fast-forward pull under $ErrorActionPreference='Continue' so a blocked or diverged pull writing to stderr doesn't throw under the launcher's 'Stop' preference and abort before the play-working-tree fallback can run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The desktop playtest launcher (
scripts/playtest.ps1) runs a fast-forwardgit pullunder$ErrorActionPreference = 'Stop'. A blocked or diverged pull writes to stderr, which underStopthrows and aborts the launcher before the "play current working tree" fallback can run — reproducing the June launch failures.Fix
Wrap the pull in
& { $ErrorActionPreference = 'Continue'; ... }so stderr no longer terminates the script; the existing$LASTEXITCODEcheck still routes a failed pull to the working-tree fallback.Also normalizes two em-dashes to ASCII in nearby comments.
🤖 Generated with Claude Code