Harden PE delayed import and dotnet blob stream parsing#2201
Open
TristanInSec wants to merge 1 commit into
Open
Harden PE delayed import and dotnet blob stream parsing#2201TristanInSec wants to merge 1 commit into
TristanInSec wants to merge 1 commit into
Conversation
Cap delayed import iteration to MAX_PE_IMPORTS, consistent with pe_parse_imports. Validate blob stream indices in the dotnet module before computing pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bounds checks to the PE delayed import parser and dotnet blob stream index handling for consistency with existing limits elsewhere in the codebase.
PE module (
pe.c):MAX_PE_IMPORTS, matching the existing limit inpe_parse_imports/pe_parse_import_descriptor.Dotnet module (
dotnet.c):Signaturecolumn values againstblob_sizebefore computing pointers into the blob heap, consistent with how other stream offsets are validated.