fix: correct attribute passing in LDAP add function#24
Open
aschumann-virtualcable wants to merge 1 commit into
Open
fix: correct attribute passing in LDAP add function#24aschumann-virtualcable wants to merge 1 commit into
aschumann-virtualcable wants to merge 1 commit into
Conversation
Corrections on servers management to delete unnecesary fields on save for weigth tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor improvements to parameter handling and correctness in the server management and LDAP utility modules.
Parameter handling improvements:
weights_min_memoryandweights_users_limitfrom the list of weight parameters in thepost_savemethod ofservers_management.py.Bug fix / correctness:
con.addinldaputil.pyto explicitly use theattributeskeyword argument, improving clarity and compatibility with the LDAP library API.Dev Explain
Corrections on servers management to delete unnecesary fields on save for weigth tab and litle change on ldaputils for attributes because con.add have dn, object_class, atributes... and generate errors