feat(api-client): robust APP_PLATFORM_MODULES parsing + bundled framework/vc-blade fixes#236
Merged
Merged
Conversation
…state All action icons in the expanded mobile toolbar now use the primary color, matching the topmost button that morphs out of the pill.
|
📦 Preview published for commit Install the preview with dist-tag: npm install @vc-shell/framework@pr-236Or pin to the exact commit: npm install @vc-shell/framework@2.0.7-pr236.b5ecb25Published packages (dist-tag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles all previously-unpushed local commits onto a single branch. The primary work is hardening
APP_PLATFORM_MODULESparsing in@vc-shell/api-client-generator; the branch also carries earlier unpushed framework and vc-blade commits.api-client: robust
APP_PLATFORM_MODULESparsingparseAndValidateArgsso it runs before any side effects (directory creation, NSwag), via a pureparsePlatformModules()returning a discriminated result.looksPartialcheck (unbalanced brackets or trailing comma) to avoid false positives on unrelated positionals.--APP_PLATFORM_MODULES=A --APP_PLATFORM_MODULES=B) —mriyields an array, which previously threw aTypeError; arrays are now joined.Parsed N module(s): …before generation so silent partial generation is visible.framework: build-info / version banner (earlier unpushed commits)
vc-blade (earlier unpushed commit)
Test Plan
yarn typecheck(api-clienttsc --noEmit) passes.'[A, B]'→Parsed 2 module(s)Parsed 2, noTypeErrorParsed 2(no false positive)A, B→ fail-fast with quoting hint, no directory created[A→ fail-fast