feat(framework): unified table row reorder + locale, theme & extension-point fixes#235
Merged
Merged
Conversation
…ed points Plugins register into extension points during module install() at app startup, while hosts declare points lazily in page setup — so getPoint() always saw an undeclared entry and warned on every page load. Registering before declaration is a supported flow, so the warning was a guaranteed false positive. Docs now recommend shared name constants for typo safety.
…vent white flash in dark theme
Stores with different locale codes but the same base language (en-US, en-GB, de-DE, de-CH) were rendered with identical labels in language lists, appearing as duplicates. Regional tags are now resolved via Intl.DisplayNames to region-qualified native names; plain two-letter codes keep the previous ISO 639-1 behavior.
…obile
Replace the native HTML5 drag-and-drop row reorder with a single SortableJS-based
mechanism that works on both the desktop table and the mobile card view. A grip
handle is shown on the left whenever `reorderable-rows` is enabled; dragging is
handle-only so row clicks, mobile swipe actions and long-press selection keep working.
The public `@row-reorder` contract ({ dragIndex, dropIndex, value }) is unchanged.
- Rewrite useTableRowReorder on SortableJS (forceFallback for touch); the orchestrator
owns one instance plus the rows-container element ref, bound to the active view.
- Revert SortableJS's DOM mutation on drop so Vue stays the source of truth
(fixes rows snapping back while sortOrder still updated).
- Add a left drag handle to the mobile card (coexists with the selection checkbox)
and stretch the mobile card view to fill the available height.
- Normalize sortOrder on load in useAssetsManager so items always carry a sequential
order even when the source provides none.
- Update tests, stories (RowReorderViaProp, MobileRowReorder) and docs.
maksimzinchuk
force-pushed
the
feat/datatable-reorder-and-framework-fixes
branch
from
f69faee to
6e1a779
Compare
|
📦 Preview published for commit Install the preview with dist-tag: npm install @vc-shell/framework@pr-235Or pin to the exact commit: npm install @vc-shell/framework@2.0.6-pr235.6e1a779Published packages (dist-tag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles one feature and four framework fixes that accumulated on this branch.
Feature
useTableRowReorderinstance, handle-only drag, touch + mouse support.Fixes
en-US,en-GB,de-DE,de-CH) rendered identical labels and appeared as duplicates in language lists. Regional tags now resolve to region-qualified native names viaIntl.DisplayNames; plain two-letter codes keep the ISO 639-1 behavior.Testing
language-serviceunit tests (incl. new regional-variant cases) — greenVcDataTable.reorder+DataTableMobileCardtests — greenyarn typecheck— clean