Verify GSL CBLAS ddot, dasum, and dscal against LAProof models#37
Open
ak-2485 wants to merge 8 commits into
Open
Verify GSL CBLAS ddot, dasum, and dscal against LAProof models#37ak-2485 wants to merge 8 commits into
ak-2485 wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
C/cblas/directory connecting three GSL CBLAS routines (cblas_ddot,cblas_dasum, andcblas_dscal) to LAProof accuracy models. The GSL CBLAS source and headers inC/cblas/srcandC/cblas/includeare taken nearly verbatim;makegenerates the Clight AST with clightgen (the*.vbuild artifacts are.gitignored, like the other C programs). The verification for each routine is organized into:*_model.v) capturing what the C loop literally computes, proved equal up tofeqto the corresponding LAProof accuracy model (dotprodF,map BABS ; sumF, and an elementwiseBMULTmap, respectively);spec_*.v), and a proof verifying the C function against it (verif_*.v).Documentation
index.htmlunder C Program Correctness Proofs, linking the model / spec / verif coqdoc pages..cnames linking tocblas_ddot.html/cblas_dasum.html/cblas_dscal.html(generated from//ldocon markers in the sources, matching thedensemat/sparseconvention).C/cblas/README.md with directory-level details on the CBLAS proofs.Future work
The current proofs assume unit stride (
incX = incY = 1), which lets the strided index variables coincide with the loop counter and makes theOFFSET/incX <= 0guards dead code. Extending to general (non-unit, possibly negative) strides is the natural next step.