[VPD-1241]: Certik reaudit upgrade Core Pool, Liquidator and Leverage Manager#716
Open
GitGuru7 wants to merge 9 commits into
Open
[VPD-1241]: Certik reaudit upgrade Core Pool, Liquidator and Leverage Manager#716GitGuru7 wants to merge 9 commits into
GitGuru7 wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the Certik "Venus Labs – Core Feature Reaudit" fixes to the BNB Chain Core Pool stack — recompiled, audited bytecode for the Comptroller diamond, ComptrollerLens, Liquidator, the standard VBep20 delegate, the LeverageStrategiesManager, and the E-brake Executor.
What changes
claimVenusAsCollateral(address,address[])andseizeVenus(address[],address,address[])— and enforces vXVS-market entry when claiming as collateral under a shortfall.seizeVenus(address[],address,address[])to the Normal / Fast-track / Critical timelocks and the critical guardian.sweepToken(address).HaltedWithoutCapCheck) if the cap read reverts, instead of using a stale reading.Testing
simulations/vip-999/{bscmainnet,bsctestnet,bsctestnet-addendum}.ts), ABIs sourced from the deployed implementations.seizeVenus/claimVenusAsCollateraloverloads, LSMsweepToken, and a cross-asset leverage round-trip via the RelativePositionManager.Note
CorrelatedTokenOracle (
setSnapshot) — intentionally deferred. The oracle fix from the same reaudit is not part of this VIP.setSnapshotis a governance-gated function and the fix only adds an input-validation safeguard (max-rate / timestamp bounds), so the residual risk is minimal. The deployed contract is left unchanged for now; any new oracle deployments can adopt the updated implementation directly.vFIL and vBUSD markets have been intentionally included in the upgrade list due to their strong available liquidity.