Skip to content

feat(themes): Online Themes CSS Override - #3017

Open
yuna0x0 wants to merge 1 commit into
Vendicated:mainfrom
yuna0x0:online-theme-override
Open

feat(themes): Online Themes CSS Override#3017
yuna0x0 wants to merge 1 commit into
Vendicated:mainfrom
yuna0x0:online-theme-override

Conversation

@yuna0x0

@yuna0x0 yuna0x0 commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

Resolves #1466.

This PR implemented an online theme CSS override feature, which allows user to configure their online theme using CSS override.

Related PR

Vencord/vencord.dev#69

Limitation

  • When there's an @import CSS at-rule in the remote stylesheet, those imported stylesheets' CSS rules won't be visible. It will make things more complex if we want to fetch and parse those stylesheets recursively.

Screenshots

Screenshot 2024-11-16 at 3 23 11 AM Screenshot 2024-11-16 at 3 23 52 AM

@yuna0x0
yuna0x0 force-pushed the online-theme-override branch 5 times, most recently from 241836f to b59f39e Compare November 15, 2024 22:23
@nakoyasha

Copy link
Copy Markdown
Contributor

I think it'd be better as a modal rather than an inline, inline (at least, from my experience) has always been a lot more messy and hard to use

@yuna0x0
yuna0x0 force-pushed the online-theme-override branch from b59f39e to 7152417 Compare November 16, 2024 00:28
@yuna0x0

yuna0x0 commented Nov 16, 2024

Copy link
Copy Markdown
Contributor Author

I think it'd be better as a modal rather than an inline, inline (at least, from my experience) has always been a lot more messy and hard to use

I agree with this. Change to modal component.

Screenshot 2024-11-16 at 8 28 26 AM Screenshot 2024-11-16 at 8 28 41 AM

@yuna0x0
yuna0x0 force-pushed the online-theme-override branch 4 times, most recently from eb3d5c1 to 1fa8aa3 Compare November 16, 2024 20:44
@yuna0x0
yuna0x0 force-pushed the online-theme-override branch 12 times, most recently from 8402dd2 to f7d3dd4 Compare November 18, 2024 00:10
@yuna0x0

yuna0x0 commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

Added handly icon buttons for quick edit and reset.

vencord-pr-3017-demo.mp4

@yuna0x0
yuna0x0 force-pushed the online-theme-override branch 4 times, most recently from 4c1f7fa to 5d97b5a Compare November 18, 2024 03:30
@yuna0x0
yuna0x0 force-pushed the online-theme-override branch 3 times, most recently from 7f1e4bf to 30c7740 Compare November 24, 2024 04:32
@yuna0x0
yuna0x0 force-pushed the online-theme-override branch 3 times, most recently from cc3af12 to f869d40 Compare November 30, 2024 01:42
@yuna0x0
yuna0x0 force-pushed the online-theme-override branch 4 times, most recently from 61840f4 to 0a8cbdb Compare December 10, 2024 05:33
@yuna0x0
yuna0x0 force-pushed the online-theme-override branch from 0a8cbdb to 191e382 Compare December 19, 2024 08:34
@yuna0x0
yuna0x0 force-pushed the online-theme-override branch from 191e382 to c84399b Compare March 14, 2025 11:27
@MiguVT

MiguVT commented Jul 28, 2025

Copy link
Copy Markdown

Any update of this? look like Vencord is not accepting new features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] A theme configurator for Vencord/Vesktop

3 participants