Skip to content

Plugin traits - #84

Draft
LazyStability wants to merge 3 commits into
Vencord:mainfrom
LazyStability:plugin-traits
Draft

Plugin traits#84
LazyStability wants to merge 3 commits into
Vencord:mainfrom
LazyStability:plugin-traits

Conversation

@LazyStability

Copy link
Copy Markdown

Motivation

Addresses Issues:

I wanted to use the AutoDNDWhilePlaying plugin and only found out that it was restricted to the official client after browsing the prs in the vencord repo. This pr aims to fix this behavior.

Features

This pr acomplishes two things.

  1. It adds a red box to each individual plugin page warning the user of incompatibilities with certain environments.
  2. It reworks the filters on the plugin index page, now the filter show all plugins that work in the selected environment. I also added an additional environment by splitting the old desktop flag into official discord client and unofficial one which I named vesktop.

Disclaimer

I am not a javascript dev and have absolutetly no idea how astro works nor have any good insight into the project itself. So if I violate any guidelines or missunderstood any of the properties please let me know (I infered the possible types from the PLUGINS_JSON_URL). I just found it very irritating that the official documentation page does not show you whether a plugin works with the version of vencord you use.

In the plugins.json file, the vencordDesktop type does not exist,
instead there only exists this new desktop type.

I treat this new type as a one to one replacement but it might very well
be:
desktop = discordDesktop ∪ vencordDesktop
This filtering shows all the valid plugins for the chosen platform,
instead of plugins which only work on the chosen platform like it did
before.

This is under the assumption that plugins with the target flag discord
require the official discord client, those with the desktop flag only on
vesktop and those with web only on the webclient.
Plugins that only work in a certain environment now have a card elements
showing which ones they work in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant