Fix undefined signed shifts in odd-bit SIMD kernels - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uint64_twithout alignment or aliasing assumptionsCause
The packed 64-bit high-bit plane was loaded as
int64_t. When bit 63 was set, the value became negative and expressions such astop_bit << 1invoked undefined behavior under C++17, which UBSan reported at runtime.Verification
git diff --check: passedGIST performance
Pinned single-thread IVF searches over all 1,000 GIST queries,
k=10,nprobe=50, seven repetitions:All result IDs and distances were exactly identical, with maximum distance delta
0.0. The sub-1% QPS variation is consistent with measurement noise. The AVX2 and AVX-512 object text sizes are unchanged, and the helper copies are fully inlined.