Closed
Conversation
|
Ping. |
Contributor
|
Thanks! I didn't merge the dbg.cpp bit. I am not setup to test freebsd, and chatgpt wasn't sure that the fix was right, so I didn't want to merge it without feeling more confident. Here's what chatgpt says: “It appears to rely on dereferencing kinfo_proc.ki_paddr (kernel pointer) instead of using the direct ki_flag field, and it also changes the macOS member access in a way that may be incorrect. This code needs FreeBSD-header/version validation before merge.” |
Contributor
|
(I did merge some of this in 2a20935) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request aiming at adding compatibility to FreeBSD. Though does build fine, the library is untested.