minor refactor#13
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the video editor UI to stop prop-drilling editor state through EditorPage and instead share the useVideoEditor() state via a new React context provider, simplifying component interfaces.
Changes:
- Added
VideoEditorContext+VideoEditorProviderand migrated editor components to consume state viauseVideoEditorContext(). - Simplified
EditorPageto render editor subcomponents without passing large prop objects. - Updated
Appto wrap the editor route in the provider and added a layout-measurement wrapper for the landing/download card.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mainview/context/VideoEditorContext.tsx | Introduces context + provider for useVideoEditor() state. |
| src/mainview/components/Timeline.tsx | Switches from prop-based state to context consumption. |
| src/mainview/components/Player.tsx | Switches from prop-based state to context consumption. |
| src/mainview/components/ExportPanel.tsx | Switches from prop-based state/callbacks to context consumption. |
| src/mainview/components/EncoderSettings.tsx | Switches from prop-based state to context consumption; reads formats from constants. |
| src/mainview/components/EditorPage.tsx | Removes extensive props surface; renders child components directly. |
| src/mainview/App.tsx | Wraps editor page in provider; adds card-height measurement logic for landing/download. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+11
to
+13
| start, | ||
| setStart, | ||
| end, |
Comment on lines
+23
to
+31
| useLayoutEffect(() => { | ||
| const element = cardRef.current; | ||
| if (element) { | ||
| const newHeight = element.offsetHeight; | ||
| if (newHeight !== cardHeight) { | ||
| setCardHeight(newHeight); | ||
| } | ||
| } | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.