ResultTensorOfTensorTA: outer tile of "regular" companion array must be TA::Tensor#515
Open
evaleev wants to merge 1 commit into
Open
ResultTensorOfTensorTA: outer tile of "regular" companion array must be TA::Tensor#515evaleev wants to merge 1 commit into
evaleev wants to merge 1 commit into
Conversation
evaleev
force-pushed
the
evaleev/tot/inner-btas-tensor
branch
2 times, most recently
from
22ae856 to
149a82d
Compare
…n array The "regular" (non-nested) companion array used in ToT * T einsum contractions had its outer tile set to the *inner* tile type of the input ToT array. For TA-inner ToT that happens to work (TA::Tensor is a valid outer tile too), but for btas-inner ToT it produced a DistArray<btas::Tensor, ...> whose tile lacks the outer-tile API einsum needs (permute/reshape/batch/...). The outer tile must always be TA::Tensor; inner-tile types like btas::Tensor are *inner-only*. Fix compatible_regular_distarray_type to wrap the inner's numeric type in TA::Tensor. Also bumps the TiledArray pin to the version that lifts the matching TA-side restrictions (ValeevGroup/tiledarray#546).
evaleev
force-pushed
the
evaleev/tot/inner-btas-tensor
branch
from
149a82d to
fc9d1f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan