feat(nfs3_client)!: add prot param to PortmapperClient::getport#161
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the nfs3_client portmapper API so PortmapperClient::getport can query ports for an explicit transport protocol instead of always assuming TCP. That brings the client closer to RFC 1057 and makes the low-level portmapper primitive usable for both TCP and UDP service discovery.
Changes:
- Extend
PortmapperClient::getportto accept aprot: u32transport-protocol argument. - Update internal client connection logic to continue requesting TCP service ports explicitly.
- Update the
portmapexample to passIPPROTO_TCPto the new API.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/nfs3_client/src/portmapper.rs |
Changes the public getport API and request construction to use a caller-supplied protocol. |
crates/nfs3_client/src/connect.rs |
Adapts connection setup to the new getport signature while preserving TCP-based resolution. |
crates/nfs3_client/examples/portmap.rs |
Updates the example client to call the new API with IPPROTO_TCP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151