Deduplicate httpx Timeout construction with match helper#2961
Closed
adamtheturtle wants to merge 4 commits intomainfrom
Closed
Deduplicate httpx Timeout construction with match helper#2961adamtheturtle wants to merge 4 commits intomainfrom
adamtheturtle wants to merge 4 commits intomainfrom
Conversation
Extract _httpx_timeout() helper using match/case to build httpx.Timeout, replacing duplicated isinstance branches in HTTPXTransport and AsyncHTTPXTransport. Closes #2960 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
Member
Author
|
Blocked on type checker bugs with match/case narrowing:
Will revisit once these are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_httpx_timeout()helper usingmatch/caseto buildhttpx.Timeout, replacing duplicatedisinstancebranches inHTTPXTransport.__call__andAsyncHTTPXTransport.__call__Closes #2960
Test plan
httpx.Timeoutvalues for bothfloatandtupleinputs🤖 Generated with Claude Code
Note
Low Risk
Low risk refactor confined to
httpxtransport timeout construction; behavior should remain the same aside from stricter type handling via the new helper.Overview
Refactors
HTTPXTransportandAsyncHTTPXTransportto use a new_httpx_timeout()helper for constructinghttpx.Timeout, removing duplicatedisinstancebranches.The helper uses
match/caseto handle(connect, read)tuples vs scalar timeouts and adds anassert_neverfallback to make unsupported types explicit.Reviewed by Cursor Bugbot for commit 4940fcb. Bugbot is set up for automated code reviews on this repo. Configure here.