Use match statements in _handle_vumark_exceptions#2135
Merged
adamtheturtle merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
Replace isinstance checks with match/case for clarity and consistency with other CLI error handling. Closes #2134 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Coverage sees the implicit fallthrough of a match statement as an uncovered branch. Using `case _:` instead of an explicit type match for the second case eliminates the uncovered branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isinstancechecks withmatch/casestatements in_handle_vumark_exceptionsfor clarity and consistency with other CLI error handling.uv.lockupdated with latest dependency versions (pyrefly 0.61.0, ty 0.0.30).Closes #2134
Test plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk refactor that preserves existing error messages/exit behavior, plus lockfile-only dev dependency bumps (
pyrefly,ty).Overview
Refactors
src/vws_cli/vumark.py’s_handle_vumark_exceptionsto replaceisinstancebranching withmatch/casewhile keeping the same user-facing error messages and exit path.Updates
uv.lockto bump dev tooling dependencies (pyreflyto0.61.0,tyto0.0.30).Reviewed by Cursor Bugbot for commit 5c0efef. Bugbot is set up for automated code reviews on this repo. Configure here.