WIP: VWBL Gatway Ver2 - #86
Open
thashimoto1998 wants to merge 44 commits into
Open
Conversation
seki-seki
approved these changes
Apr 30, 2024
seki-seki
left a comment
seki-seki
left a comment
Contributor
There was a problem hiding this comment.
一点コメントしましたが、この実装方針でいいと思います
| * Their allocation numerators are deleted, effectively removing them from the active validator set. | ||
| * @param newValidators An array of validator addresses that represents the new active validator set. | ||
| */ | ||
| function unregisterLeaveValidators(address[] memory newValidators) private { |
Contributor
Author
There was a problem hiding this comment.
確かにです。leaveValidatorsに修正します。
Contributor
|
あ、fiatnameからfiatIndexが引けるようにしといたほうがいいな |
feat: update hardhat package
Tmp/gatewayv2test
feat: grant view permission
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.