MENG-1939 Command Timed Out caused Actor crashed#8
Merged
bohyuanchao merged 1 commit intoAug 5, 2025
Conversation
aukeman
reviewed
Aug 5, 2025
| if dial_command.respond_to?(:timestamp) | ||
| @start_time = dial_command.timestamp.to_time | ||
| else | ||
| logger.warn "dial_command #{dial_command.inspect} did not respond to timestamp. @dial_command #{@dial_command.inspect}" |
There was a problem hiding this comment.
do we need to set some @start_time to some value? or is it ok if it's null?
any idea under what condition the dial_command doesn't have a timestamp set?
Author
There was a problem hiding this comment.
do we need to set some @start_time to some value? or is it ok if it's null?
I think it should be fine since we don't use Adhearsion::Call#start_time for anything in the voice.
any idea under what condition the dial_command doesn't have a timestamp set?
When commands timed out, we ignore the timeout on purpose
https://github.com/VHT/callback_cloud/blob/comintg/voice/lib/outbound_call_extensions.rb#L7
aukeman
approved these changes
Aug 5, 2025
|
👍 seems to make sense to keep the celluloid actor from crashing |
tomeeo
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.medallia.com/browse/MENG-1939