Skip to content

OPC-1507 | Genesys XXE Vulnerability #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jspencer92 wants to merge 1 commit into
base: 6.4.0
Choose a base branch
from
Open

OPC-1507 | Genesys XXE Vulnerability #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...eclipse.vtp.framework.util/src/main/java/org/eclipse/vtp/framework/util/XMLUtilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,21 @@ public static DocumentBuilder getDocumentBuilder()
throws ParserConfigurationException {
DocumentBuilderFactory documentBuilderFactory = DocumentBuilderFactory
.newInstance();
// Harden the parser against XML External Entity (XXE) attacks
// (CWE-611). This utility is shared across the framework, so any caller
// that parses untrusted XML (e.g. Genesys attached data) inherits a
// safe-by-default parser. See the OWASP XXE Prevention Cheat Sheet.
documentBuilderFactory.setFeature(
"http://apache.org/xml/features/disallow-doctype-decl", true);
documentBuilderFactory.setFeature(
"http://xml.org/sax/features/external-general-entities", false);
documentBuilderFactory.setFeature(
"http://xml.org/sax/features/external-parameter-entities", false);
documentBuilderFactory.setFeature(
"http://apache.org/xml/features/nonvalidating/load-external-dtd",
false);
documentBuilderFactory.setXIncludeAware(false);
documentBuilderFactory.setExpandEntityReferences(false);
Comment on lines +489 to +503

return documentBuilderFactory.newDocumentBuilder();
}
Expand Down