fix: switch to gen-lsp-types#459
Conversation
[gen-lsp-types](https://github.com/ribru17/gen-lsp-types) is an alternative to the lsp-types crate, with types generated via codegen from the official LSP Metamodel for correctness and completeness. lsp-types issues fixed in gen-lsp-types: - gluon-lang/lsp-types#310 - gluon-lang/lsp-types#308 - gluon-lang/lsp-types#284 - gluon-lang/lsp-types#278 - gluon-lang/lsp-types#277 - gluon-lang/lsp-types#260 - gluon-lang/lsp-types#245 - gluon-lang/lsp-types#93
|
Hi and thanks for the PR! I have checked out your project and I really like it. Your design decisions look solid and some of the pain points you address are ones I've also hit in That being said, my major concern with your PR is stability: I don't have an immediate problem with In any case, I'm strongly considering switching — either when I hit a feature |
|
Thanks for the feedback! Lack of stability is a very valid point. In that case, maybe you should wait on this PR. I think there shouldn't be any more breaking versions coming in the future, aside from those due to actual LSP metamodel updates. That said, there might be something that comes up which requires a breaking fix, and just in case maybe we should hold off on this? That said, I'll try my best not to have this be the case, especially since the library is used in a couple of projects now. |
gen-lsp-types is an alternative to the lsp-types crate, with types generated via codegen from the official LSP Metamodel for correctness and completeness.
lsp-types issues fixed in gen-lsp-types:
SnippetTextEditsupport (proposed) gluon-lang/lsp-types#310Uritype in 0.96.0 is hard to use and have almost no interoperability gluon-lang/lsp-types#284DefaultforCodeActionOptionsgluon-lang/lsp-types#260