Skip to content

vproxy: add icap tcp connect timeout#69

Draft
DanielHaimanot wants to merge 1 commit into
VEY-OSS:mainfrom
DanielHaimanot:vproxy_icap_connect
Draft

vproxy: add icap tcp connect timeout#69
DanielHaimanot wants to merge 1 commit into
VEY-OSS:mainfrom
DanielHaimanot:vproxy_icap_connect

Conversation

@DanielHaimanot

@DanielHaimanot DanielHaimanot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Problem / Solution

Adds a configurable tcp_connect_timeout to the ICAP module's connection
establishment path. Previously socket.connect() was awaited with no bound,
leaving dials to the OS default.

Change

  • IcapServiceConfig gains tcp_connect_timeout (default: 1s)
  • connect() wraps the dial in tokio::time::timeout

Closes #66

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/vey-icap-client/src/service/connection.rs 33.33% 6 Missing ⚠️
lib/vey-icap-client/src/service/config/yaml.rs 20.00% 4 Missing ⚠️
lib/vey-icap-client/src/service/config/mod.rs 25.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread lib/vey-icap-client/src/service/connection.rs
Comment thread lib/vey-icap-client/Cargo.toml
Comment thread sphinx/vey-values/configuration/values/audit.rst
@zh-jq

zh-jq commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

It seems we should also add a timeout limit to the ICAP OPTIONS request.

@DanielHaimanot

Copy link
Copy Markdown
Contributor Author

It seems we should also add a timeout limit to the ICAP OPTIONS request.

right, I also prefer moving OPTIONS request out of the client and respect the TTL given by the ICAP server.

@DanielHaimanot
DanielHaimanot marked this pull request as draft July 20, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICAP: no connect/OPTIONS timeout — a black-holed ICAP server hangs every request for the full OS SYN timeout, bypass does not help

2 participants