vproxy: add icap tcp connect timeout#69
Draft
DanielHaimanot wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
zh-jq
requested changes
Jul 19, 2026
Contributor
|
It seems we should also add a timeout limit to the ICAP OPTIONS request. |
Contributor
Author
right, I also prefer moving OPTIONS request out of the client and respect the TTL given by the ICAP server. |
DanielHaimanot
marked this pull request as draft
July 20, 2026 04:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Solution
Adds a configurable
tcp_connect_timeoutto the ICAP module's connectionestablishment path. Previously
socket.connect()was awaited with no bound,leaving dials to the OS default.
Change
IcapServiceConfiggainstcp_connect_timeout(default: 1s)connect()wraps the dial intokio::time::timeoutCloses #66